Christian 'ketura' McCarty
5fbe0aabd2
Fixed Catapult crashing the game when the opponent has 0 cards in deck.
2025-04-10 17:28:10 -05:00
Christian 'ketura' McCarty
acf73f4383
Fixed His First Serious Check failing to discard the card after paying the twilight
2025-04-10 10:25:53 -05:00
Christian 'ketura' McCarty
7937ee914a
more V2 tests
2025-04-09 22:11:06 -05:00
Christian 'ketura' McCarty
fc9f1b1f70
Adding a null check to a section of the game animation code that causes a bizarre visual crash out when reloading at the wrong time
2025-04-09 20:26:59 -05:00
Christian 'ketura' McCarty
a965c106c4
Unfolding more cards from unnecessary (I hope) CostToEffect wrappers
2025-04-09 20:14:08 -05:00
Christian 'ketura' McCarty
75bd836c62
Optional effect type overhaul
...
- So it turns out that Optional is frequently used to wrap a CostToEffect, but because of how that's set up the Optional does not ensure the "Cost" part is actually enforced. Thus someone can choose "yes" and it will always treat both halves of a CostToEffect as optional.
- Added the standard "requires" and "cost" fields to Optional
- Refactored about 30 cards to no longer use CostToEffect nested within an Optional, instead opting to use the cost field of Optional itself
2025-04-08 23:21:40 -05:00
Christian 'ketura' McCarty
2fd2958fab
Fixing Beyond All Darkness (and other "put cards from hand on the bottom of the deck" cards) revealing the cards to the wrong player
2025-04-08 17:06:58 -05:00
Christian 'ketura' McCarty
204010b7e5
added test cases for all Elven cards from V2
2025-04-07 22:33:53 -05:00
Christian 'ketura' McCarty
ba273f06f8
Added unit tests for all V2 Dunland cards; cleaned up the tests for the V2 Maps.
2025-04-07 19:50:48 -05:00
Christian 'ketura' McCarty
8f56866ad0
Fixed V2 An End Worthy of Remembrance never being playable
2025-04-07 18:23:33 -05:00
Christian 'ketura' McCarty
aa961a6b8e
Merge branch 'master' into bug/march-bugs
2025-04-07 13:07:13 -05:00
Christian 'ketura' McCarty
941201af9f
Fixed V2 Breaching Shot being playable if there aren't enough tokens on machines to assign an uruk, and also fixed it crashing the game if not enough tokens were removed to assign an uruk.
2025-04-07 13:05:08 -05:00
Christian 'ketura' McCarty
dc41cdb0cf
Missing test function
2025-04-06 23:18:17 -05:00
Christian McCarty
e05c6bac3a
Merge pull request #593 from PlayersCouncil/bug/march-bugs
...
Yet Even More Bugs Once Again
2025-04-06 23:02:51 -05:00
Christian 'ketura' McCarty
a90842b1bf
Fixed V2 Saruman not preventing all sources of damage bonuses.
2025-04-06 21:41:23 -05:00
Christian 'ketura' McCarty
bdc1da9c42
Fixed V2 Isengard Grunt not increasing the overwhelm multiplier.
2025-04-06 20:49:09 -05:00
Christian 'ketura' McCarty
3d39aa8309
Fixed salve for really real this time.
2025-04-06 20:23:16 -05:00
Christian 'ketura' McCarty
c1e02b8fa5
Fixing a login issue with password reset
2025-04-06 17:50:02 -05:00
Christian 'ketura' McCarty
ac22e0644d
Fixed Into the Caves, for realsies this time.
2025-04-06 17:07:55 -05:00
Christian 'ketura' McCarty
91024f1f29
Adjusting Writhiing Tentacle to not permit itself to be chosen (which may happen if it is played at a non-marsh)
2025-04-06 13:34:01 -05:00
Christian 'ketura' McCarty
bb22a51a4f
Fixing Hill Clan granting damage +1 instead of damage +2.
2025-04-06 12:20:27 -05:00
Christian 'ketura' McCarty
3b415f34b2
Fixed the tournament/league name validation being exactly backwards and only permitting event creation if the name was too long
2025-04-05 13:48:28 -05:00
Christian 'ketura' McCarty
17409b22dd
Merge branch 'master' into bug/march-bugs
2025-04-05 12:30:14 -05:00
Christian 'ketura' McCarty
ca0f7fbe0e
Fixed Morgul Squealer permitting itself to be selected as a card to play from discard.
2025-04-05 12:29:48 -05:00
Christian McCarty
40990c79d2
Merge pull request #580 from PlayersCouncil/bug/march-bugs
...
April card fixes
2025-04-01 22:19:39 -05:00
Christian 'ketura' McCarty
e8b5aef04a
Fixed Highest Quality never being playable.
2025-04-01 22:09:18 -05:00
Christian 'ketura' McCarty
cb1d158d5a
Fixed Above the Battlements test cases
2025-04-01 21:35:08 -05:00
Christian 'ketura' McCarty
5c793e2943
Cleaning up the floating-attached fix from phallen and applying it to PutCardsFromPlayOnTopOfDeck as well.
2025-04-01 21:34:53 -05:00
Christian 'ketura' McCarty
436a9d97b5
Fixed the Siege Engine fix, added test cases
2025-04-01 21:34:24 -05:00
Christian 'ketura' McCarty
6b5b3daffb
Merge remote-tracking branch 'phallen/patch-5' into bug/march-bugs
2025-04-01 20:57:48 -05:00
Christian 'ketura' McCarty
91b107eac5
Merge remote-tracking branch 'phallen/patch-10' into bug/march-bugs
2025-04-01 20:47:54 -05:00
Christian 'ketura' McCarty
38974c45a3
Fixed Salve not preventing wounds (and not restricting itself to only lethal wounds)
2025-04-01 20:45:39 -05:00
Christian 'ketura' McCarty
778a33606f
Merge branch 'master' into bug/march-bugs
2025-04-01 20:39:33 -05:00
Christian 'ketura' McCarty
037bc4dc2a
Kill Trigger Overhaul
...
- Reworked the Killed trigger to more robustly handle lethal wounds without doubling triggers
- Migrated AT for More Yet To Come
- Fixed Mind and Body for good this time
- Fixed various cards with kill triggers triggering twice when killed by a wound
2025-04-01 20:38:37 -05:00
Christian 'ketura' McCarty
071c8ef494
Refactoring Filters.accepts to mirror the signature of Filters.acceptsAny
2025-04-01 19:21:44 -05:00
Christian 'ketura' McCarty
2662e5a260
Fixed league preview not checking/enforcing that the event name is <= the database limit of 45 characters.
2025-04-01 17:20:04 -05:00
Christian McCarty
ed828bfc9a
Merge pull request #583 from PlayersCouncil/preparations
...
Fix: Preparations allowing allies to exert
2025-04-01 17:04:50 -05:00
Devon Henegar
763ea49d47
Fix: Preparations allowing allies to exert
2025-04-01 14:41:04 -04:00
Christian 'ketura' McCarty
b1abddbce5
printedTwilightCostFromMemory change
...
- Reverted printedTwilightCostFromMemory filter to use card memory reference.
- Added MatchesTwilight for an exact numeric match of the twilight cost of a card
- Altered Gathering Wind to use MatchesTwilight, since it is having the player choose an arbitrary number
- Fixed Catapult crashing the game due to the card reference
2025-04-01 08:06:37 -05:00
Christian McCarty
592ebf8dd2
Merge pull request #567 from PlayersCouncil/bug/march-bugs
...
more card fixes
2025-03-30 23:58:53 -05:00
Christian 'ketura' McCarty
7e3764b61a
Fixed The Tale of the Great Ring failing to prevent overwhelm if the hobbit's strength is reduced to 0.
2025-03-30 16:20:31 -05:00
Christian 'ketura' McCarty
b0aac19d1d
Skirmish Resolution Overhaul
...
- Overhauled the skirmish resolution code to involve far less repetitive copy-pasted code. Eliminated code that emitted a "skirmish lost" trigger for characters removed early from a skirmish (this behavior was superceded in a later CRD)
- Consolidated the separate SkirmishType enums instead of having a separate enum for Overwhelm and Normal skirmish types (that had the exact same contents)
- Fixed Dwarven Axe (and any other "skirmish loss" triggers) incorrectly triggering on a character that has been removed from a skirmish before it resolves.
2025-03-30 14:19:15 -05:00
Christian 'ketura' McCarty
0cc87234b7
Fixed the log messages for normal skirmish evaluations being flipped for freeps/shadow
2025-03-30 12:18:35 -05:00
Christian 'ketura' McCarty
4f7408cc9c
Fixing daily and ad-hoc tournaments not properly requiring decks to be provided
2025-03-28 09:00:00 -05:00
Christian 'ketura' McCarty
af385a7309
Query for pulling starter usage statistics from the sealed masters events
2025-03-28 08:47:41 -05:00
PhallenCassidy
f88c8b3cc4
Fix for Siege Engine
2025-03-27 14:33:43 -04:00
Christian 'ketura' McCarty
932d929b82
Fixed PC-Movie format not having the Rohan culture filter in the deckbuilder.
2025-03-26 00:07:32 -05:00
PhallenCassidy
fcface089b
Fix for Above the Battlement
...
This card has two effects rather than two costs
2025-03-25 15:18:16 -04:00
Christian 'ketura' McCarty
cfee379a91
Restored flag on play-from-deck effects so that "play from your draw deck or discard pile" actions don't present a false option to the player. Hopefully? Fixed Theoden, Tall and Proud sometimes not triggering.
2025-03-25 05:35:58 -05:00
PhallenCassidy
afb83d5ec9
Fix for Borders of the Forest
...
Workaround for the effect is no longer required, and also broken.
2025-03-24 16:52:20 -04:00
