Christian 'ketura' McCarty
17409b22dd
Merge branch 'master' into bug/march-bugs
2025-04-05 12:30:14 -05:00
Christian 'ketura' McCarty
ca0f7fbe0e
Fixed Morgul Squealer permitting itself to be selected as a card to play from discard.
2025-04-05 12:29:48 -05:00
Christian McCarty
40990c79d2
Merge pull request #580 from PlayersCouncil/bug/march-bugs
...
April card fixes
2025-04-01 22:19:39 -05:00
Christian 'ketura' McCarty
e8b5aef04a
Fixed Highest Quality never being playable.
2025-04-01 22:09:18 -05:00
Christian 'ketura' McCarty
cb1d158d5a
Fixed Above the Battlements test cases
2025-04-01 21:35:08 -05:00
Christian 'ketura' McCarty
5c793e2943
Cleaning up the floating-attached fix from phallen and applying it to PutCardsFromPlayOnTopOfDeck as well.
2025-04-01 21:34:53 -05:00
Christian 'ketura' McCarty
436a9d97b5
Fixed the Siege Engine fix, added test cases
2025-04-01 21:34:24 -05:00
Christian 'ketura' McCarty
6b5b3daffb
Merge remote-tracking branch 'phallen/patch-5' into bug/march-bugs
2025-04-01 20:57:48 -05:00
Christian 'ketura' McCarty
91b107eac5
Merge remote-tracking branch 'phallen/patch-10' into bug/march-bugs
2025-04-01 20:47:54 -05:00
Christian 'ketura' McCarty
38974c45a3
Fixed Salve not preventing wounds (and not restricting itself to only lethal wounds)
2025-04-01 20:45:39 -05:00
Christian 'ketura' McCarty
778a33606f
Merge branch 'master' into bug/march-bugs
2025-04-01 20:39:33 -05:00
Christian 'ketura' McCarty
037bc4dc2a
Kill Trigger Overhaul
...
- Reworked the Killed trigger to more robustly handle lethal wounds without doubling triggers
- Migrated AT for More Yet To Come
- Fixed Mind and Body for good this time
- Fixed various cards with kill triggers triggering twice when killed by a wound
2025-04-01 20:38:37 -05:00
Christian 'ketura' McCarty
071c8ef494
Refactoring Filters.accepts to mirror the signature of Filters.acceptsAny
2025-04-01 19:21:44 -05:00
Christian 'ketura' McCarty
2662e5a260
Fixed league preview not checking/enforcing that the event name is <= the database limit of 45 characters.
2025-04-01 17:20:04 -05:00
Christian McCarty
ed828bfc9a
Merge pull request #583 from PlayersCouncil/preparations
...
Fix: Preparations allowing allies to exert
2025-04-01 17:04:50 -05:00
Devon Henegar
763ea49d47
Fix: Preparations allowing allies to exert
2025-04-01 14:41:04 -04:00
Christian 'ketura' McCarty
b1abddbce5
printedTwilightCostFromMemory change
...
- Reverted printedTwilightCostFromMemory filter to use card memory reference.
- Added MatchesTwilight for an exact numeric match of the twilight cost of a card
- Altered Gathering Wind to use MatchesTwilight, since it is having the player choose an arbitrary number
- Fixed Catapult crashing the game due to the card reference
2025-04-01 08:06:37 -05:00
Christian McCarty
592ebf8dd2
Merge pull request #567 from PlayersCouncil/bug/march-bugs
...
more card fixes
2025-03-30 23:58:53 -05:00
Christian 'ketura' McCarty
7e3764b61a
Fixed The Tale of the Great Ring failing to prevent overwhelm if the hobbit's strength is reduced to 0.
2025-03-30 16:20:31 -05:00
Christian 'ketura' McCarty
b0aac19d1d
Skirmish Resolution Overhaul
...
- Overhauled the skirmish resolution code to involve far less repetitive copy-pasted code. Eliminated code that emitted a "skirmish lost" trigger for characters removed early from a skirmish (this behavior was superceded in a later CRD)
- Consolidated the separate SkirmishType enums instead of having a separate enum for Overwhelm and Normal skirmish types (that had the exact same contents)
- Fixed Dwarven Axe (and any other "skirmish loss" triggers) incorrectly triggering on a character that has been removed from a skirmish before it resolves.
2025-03-30 14:19:15 -05:00
Christian 'ketura' McCarty
0cc87234b7
Fixed the log messages for normal skirmish evaluations being flipped for freeps/shadow
2025-03-30 12:18:35 -05:00
Christian 'ketura' McCarty
4f7408cc9c
Fixing daily and ad-hoc tournaments not properly requiring decks to be provided
2025-03-28 09:00:00 -05:00
Christian 'ketura' McCarty
af385a7309
Query for pulling starter usage statistics from the sealed masters events
2025-03-28 08:47:41 -05:00
PhallenCassidy
f88c8b3cc4
Fix for Siege Engine
2025-03-27 14:33:43 -04:00
Christian 'ketura' McCarty
932d929b82
Fixed PC-Movie format not having the Rohan culture filter in the deckbuilder.
2025-03-26 00:07:32 -05:00
PhallenCassidy
fcface089b
Fix for Above the Battlement
...
This card has two effects rather than two costs
2025-03-25 15:18:16 -04:00
Christian 'ketura' McCarty
cfee379a91
Restored flag on play-from-deck effects so that "play from your draw deck or discard pile" actions don't present a false option to the player. Hopefully? Fixed Theoden, Tall and Proud sometimes not triggering.
2025-03-25 05:35:58 -05:00
PhallenCassidy
afb83d5ec9
Fix for Borders of the Forest
...
Workaround for the effect is no longer required, and also broken.
2025-03-24 16:52:20 -04:00
PhallenCassidy
d6a2e57f9a
Fix for Moon-letters
2025-03-24 15:56:36 -04:00
Christian 'ketura' McCarty
7c6d77a01f
Fixed Eowyn, Northwoman and Into the Caves never being usable.
2025-03-24 08:28:44 -05:00
Christian 'ketura' McCarty
905093a5ac
Fixing V2 sites not showing up under Towers Block for PC-Movie in the deckbuilder
2025-03-24 00:13:00 -05:00
Christian McCarty
1be83758ce
Merge pull request #564 from PlayersCouncil/bug/march-bugs
...
Yet even more card bug fixes
2025-03-23 23:25:28 -05:00
PhallenCassidy
e4fb9b8148
Discard attached cards when moving a card to the bottom of the deck
2025-03-23 23:05:14 -04:00
Christian 'ketura' McCarty
6b329bad11
Reinstated automatic English translation on hover-over for tengwar, as an official feature now instead of an accident that stopped working.
2025-03-23 21:10:32 -05:00
Christian 'ketura' McCarty
6fd2daf4d7
Fixed site block filter not showing errata in PC-Movie
2025-03-23 18:42:59 -05:00
Christian 'ketura' McCarty
123dc2e6cf
Improving skirmish log message specificity
2025-03-23 18:41:26 -05:00
Christian 'ketura' McCarty
e3d3ce6843
Helpless errata, Pale Blade, Band of Wild Men unit tests
2025-03-23 18:39:34 -05:00
Christian 'ketura' McCarty
75818746f6
Fixed old V1 Gimli MW ID being issued in PC packs
2025-03-23 17:18:29 -05:00
Christian 'ketura' McCarty
fd36d7834c
Unit Tests for The Witch-king's Beast
2025-03-23 14:31:25 -05:00
Christian 'ketura' McCarty
f3cc6f136e
Adding unit tests for Band of Wild Men, confirming #516 isn't a bug.
2025-03-23 14:24:39 -05:00
Christian 'ketura' McCarty
0be506baa7
Fixed Crashed Gate causing a crash.
...
- Added SiteAvailableToControl requirement that checks that there is a valid controllable site to be targeted by site control actions.
- Altered site control checking to use a shared GameUtils function for that purpose
- Fixed HasMemory throwing an exception when the given memory location didn't exist (d'oh)
2025-03-23 13:55:54 -05:00
Christian McCarty
88fe1705a2
Merge pull request #558 from PlayersCouncil/bug/march-bugs
...
Bug/march bugs
2025-03-23 00:33:28 -05:00
Christian 'ketura' McCarty
1732427f2b
Fixed Blood Has Been Spilled being unusable.
2025-03-22 21:38:19 -05:00
Christian 'ketura' McCarty
7d36c436e0
Fixed Trample not communicating which companion is to be discarded.
2025-03-22 21:10:17 -05:00
Christian 'ketura' McCarty
d598486f91
Reinstating the ChooseOpponent effect type
...
- Reinstated ChooseOpponent and ChooseOpponentEffect (these really shouldn't have been deleted in the first place, as they will be crucial once multiplayer is worked on)
- Renamed HasInMemory -> HasCardInMemory
- Added HasMemory effect for checking whether anything has been saved to a given memory key
- Fixed Crashed Gate auto-adding threats if no site can be controlled
- Added missing Hunter keyword to the previous Elven Guardian fix unit tests
2025-03-22 20:50:03 -05:00
Christian 'ketura' McCarty
0580fa4da6
Fixed DiscardFromPlay effects not defining the correct performing player
2025-03-22 18:19:12 -05:00
Christian 'ketura' McCarty
1db9963a31
Fixed Elven Guardian PC Errata not having the Hunter 1 keyword.
2025-03-22 16:14:25 -05:00
Christian 'ketura' McCarty
7f469f7579
Fixed RemoveTokensCumulative not having a generic "any token" option. Fixed Corsair Freebooter not triggering on play.
2025-03-22 16:08:49 -05:00
Christian 'ketura' McCarty
da90aab1e4
Unit tests for Above the Battlement
2025-03-22 15:26:22 -05:00
Christian 'ketura' McCarty
834261e163
Renaming unit test functions to match naming convention
2025-03-22 15:17:42 -05:00
