Christian 'ketura' McCarty
b0aac19d1d
Skirmish Resolution Overhaul
...
- Overhauled the skirmish resolution code to involve far less repetitive copy-pasted code. Eliminated code that emitted a "skirmish lost" trigger for characters removed early from a skirmish (this behavior was superceded in a later CRD)
- Consolidated the separate SkirmishType enums instead of having a separate enum for Overwhelm and Normal skirmish types (that had the exact same contents)
- Fixed Dwarven Axe (and any other "skirmish loss" triggers) incorrectly triggering on a character that has been removed from a skirmish before it resolves.
2025-03-30 14:19:15 -05:00
Christian 'ketura' McCarty
0cc87234b7
Fixed the log messages for normal skirmish evaluations being flipped for freeps/shadow
2025-03-30 12:18:35 -05:00
Christian 'ketura' McCarty
4f7408cc9c
Fixing daily and ad-hoc tournaments not properly requiring decks to be provided
2025-03-28 09:00:00 -05:00
Christian 'ketura' McCarty
af385a7309
Query for pulling starter usage statistics from the sealed masters events
2025-03-28 08:47:41 -05:00
jakub.salavec
0229f67dfe
Optional Ready Check for tournament queues; Draft auto-picking after 3 missed cards; Queue max players fix; Draft timers do not extend time for first card
2025-03-27 20:53:16 +01:00
jakub.salavec
a6a0ffb543
Constructed tournaments deck fix
2025-03-27 20:16:48 +01:00
PhallenCassidy
f88c8b3cc4
Fix for Siege Engine
2025-03-27 14:33:43 -04:00
Christian 'ketura' McCarty
932d929b82
Fixed PC-Movie format not having the Rohan culture filter in the deckbuilder.
2025-03-26 00:07:32 -05:00
PhallenCassidy
fcface089b
Fix for Above the Battlement
...
This card has two effects rather than two costs
2025-03-25 15:18:16 -04:00
Christian 'ketura' McCarty
cfee379a91
Restored flag on play-from-deck effects so that "play from your draw deck or discard pile" actions don't present a false option to the player. Hopefully? Fixed Theoden, Tall and Proud sometimes not triggering.
2025-03-25 05:35:58 -05:00
PhallenCassidy
afb83d5ec9
Fix for Borders of the Forest
...
Workaround for the effect is no longer required, and also broken.
2025-03-24 16:52:20 -04:00
PhallenCassidy
d6a2e57f9a
Fix for Moon-letters
2025-03-24 15:56:36 -04:00
jakub.salavec
fb926d1224
Power max Bill the Pony added to starting cards, booster count 6 -> 4, one common added to each pack (15 cards); Ttt draft pack fix (alliance reforged - > Search Far and Wide)
2025-03-24 16:53:40 +01:00
Christian 'ketura' McCarty
7c6d77a01f
Fixed Eowyn, Northwoman and Into the Caves never being usable.
2025-03-24 08:28:44 -05:00
jakub.salavec
b0815ee601
Making table draft thread safe and reducing the number of public method calls
2025-03-24 13:58:52 +01:00
Christian 'ketura' McCarty
905093a5ac
Fixing V2 sites not showing up under Towers Block for PC-Movie in the deckbuilder
2025-03-24 00:13:00 -05:00
Christian McCarty
1be83758ce
Merge pull request #564 from PlayersCouncil/bug/march-bugs
...
Yet even more card bug fixes
2025-03-23 23:25:28 -05:00
PhallenCassidy
e4fb9b8148
Discard attached cards when moving a card to the bottom of the deck
2025-03-23 23:05:14 -04:00
Christian 'ketura' McCarty
6b329bad11
Reinstated automatic English translation on hover-over for tengwar, as an official feature now instead of an accident that stopped working.
2025-03-23 21:10:32 -05:00
Christian 'ketura' McCarty
6fd2daf4d7
Fixed site block filter not showing errata in PC-Movie
2025-03-23 18:42:59 -05:00
Christian 'ketura' McCarty
123dc2e6cf
Improving skirmish log message specificity
2025-03-23 18:41:26 -05:00
Christian 'ketura' McCarty
e3d3ce6843
Helpless errata, Pale Blade, Band of Wild Men unit tests
2025-03-23 18:39:34 -05:00
Christian 'ketura' McCarty
75818746f6
Fixed old V1 Gimli MW ID being issued in PC packs
2025-03-23 17:18:29 -05:00
Christian 'ketura' McCarty
fd36d7834c
Unit Tests for The Witch-king's Beast
2025-03-23 14:31:25 -05:00
Christian 'ketura' McCarty
f3cc6f136e
Adding unit tests for Band of Wild Men, confirming #516 isn't a bug.
2025-03-23 14:24:39 -05:00
Christian 'ketura' McCarty
0be506baa7
Fixed Crashed Gate causing a crash.
...
- Added SiteAvailableToControl requirement that checks that there is a valid controllable site to be targeted by site control actions.
- Altered site control checking to use a shared GameUtils function for that purpose
- Fixed HasMemory throwing an exception when the given memory location didn't exist (d'oh)
2025-03-23 13:55:54 -05:00
Christian McCarty
88fe1705a2
Merge pull request #558 from PlayersCouncil/bug/march-bugs
...
Bug/march bugs
2025-03-23 00:33:28 -05:00
Christian 'ketura' McCarty
1732427f2b
Fixed Blood Has Been Spilled being unusable.
2025-03-22 21:38:19 -05:00
Christian 'ketura' McCarty
7d36c436e0
Fixed Trample not communicating which companion is to be discarded.
2025-03-22 21:10:17 -05:00
Christian 'ketura' McCarty
d598486f91
Reinstating the ChooseOpponent effect type
...
- Reinstated ChooseOpponent and ChooseOpponentEffect (these really shouldn't have been deleted in the first place, as they will be crucial once multiplayer is worked on)
- Renamed HasInMemory -> HasCardInMemory
- Added HasMemory effect for checking whether anything has been saved to a given memory key
- Fixed Crashed Gate auto-adding threats if no site can be controlled
- Added missing Hunter keyword to the previous Elven Guardian fix unit tests
2025-03-22 20:50:03 -05:00
Christian 'ketura' McCarty
0580fa4da6
Fixed DiscardFromPlay effects not defining the correct performing player
2025-03-22 18:19:12 -05:00
Christian 'ketura' McCarty
1db9963a31
Fixed Elven Guardian PC Errata not having the Hunter 1 keyword.
2025-03-22 16:14:25 -05:00
Christian 'ketura' McCarty
7f469f7579
Fixed RemoveTokensCumulative not having a generic "any token" option. Fixed Corsair Freebooter not triggering on play.
2025-03-22 16:08:49 -05:00
Christian 'ketura' McCarty
da90aab1e4
Unit tests for Above the Battlement
2025-03-22 15:26:22 -05:00
Christian 'ketura' McCarty
834261e163
Renaming unit test functions to match naming convention
2025-03-22 15:17:42 -05:00
Christian 'ketura' McCarty
bf4a6868a3
Fixed Harmless highlighting itself even when it's already been transferred to a companion.
2025-03-22 13:35:18 -05:00
Christian 'ketura' McCarty
be2d469b00
V2 Balrog fixes
...
- Altered the UsesSpecialAbility trigger to take a player, which is more robust than using a side filter (as it isn't thwarted by the One Ring or sites)
- This required adding performing player parameters to a number of levels on the effect
- Added unit tests for the V2 Balrog
2025-03-22 13:31:24 -05:00
Christian 'ketura' McCarty
b2f77d2ff4
Fixing ChooseANumber
...
- Adding log message output to indicate what numbers are being chosen
- Fixed PrintedTwilightCostFromMemory not extracting the stored number from memory
- Fixed Gathering Wind not working.
2025-03-22 11:17:33 -05:00
Christian 'ketura' McCarty
552171449e
Fixed Attunement not revealing the cards to players.
2025-03-22 01:02:16 -05:00
Christian McCarty
bbde37fbae
Merge pull request #557 from PlayersCouncil/bug/march-bugs
...
More card fixes
2025-03-21 22:30:58 -05:00
Christian 'ketura' McCarty
4f9584853a
Fixed the various versions of Cavern Entrance blocking the use of events that self-play from the discard pile.
2025-03-21 22:24:42 -05:00
Christian 'ketura' McCarty
87c490256d
Added absolute value coercer. Fixed Treebeard, Enraged Shephard causing a game crash when winning against Enquea TOTO.
2025-03-21 22:18:06 -05:00
Christian 'ketura' McCarty
3cb492657f
Fixed Din of Arms executing the second part of its game text if the top card could not be discard (due to e.g. Courteous Halfing).
2025-03-21 21:39:03 -05:00
Christian 'ketura' McCarty
f6b668c8b8
Fixed Ulaire Attea, Second of the Nine Riders not restricting itself to only fierce skirmishes.
2025-03-21 21:34:11 -05:00
Christian 'ketura' McCarty
3bf3d774ee
Moved the skirmish about to end trigger to before skirmish resolution, which should fix certain skirmish responses getting swalled by overwhelm results. As a result, fixed Sting, Bane of the Eight Legs (and others) not triggering during an overwhelm.
2025-03-21 21:33:47 -05:00
Christian 'ketura' McCarty
c1c4b5204e
Added unit tests for Pinnacle of Zirak-zigal
2025-03-21 20:58:08 -05:00
Christian 'ketura' McCarty
86037ffa05
Added OwnerControls filter for better handling of sites like Nurn. Fixed Nurn affecting both player's minions.
2025-03-21 19:58:08 -05:00
jakub.salavec
c672b43d7e
Table draft formats are now defined via json and can be reloaded without server restart; Table draft formats now show names instead of codes in tournament admin view; Removed unused Solo Table Draft code from tournament service;
2025-03-21 14:19:48 +01:00
Christian 'ketura' McCarty
713c8f4bc0
Added custom text to make the two options on V1 Library of Rivendell easier to distinguish.
2025-03-20 19:29:30 -05:00
Christian 'ketura' McCarty
5ec3d78c3f
Fixed Ride With Me failing if Theoden was unable to be exerted.
2025-03-20 19:14:11 -05:00
