Nathaniel Bond
b7d8b06888
Refactor deck naming
2024-12-30 10:35:57 -05:00
Nathaniel Bond
f71eda27ac
Correct logic
2024-12-30 10:07:39 -05:00
Nathaniel Bond
c14aefa04c
Try normalizing new deck effect
2024-12-30 10:02:55 -05:00
Nathaniel Bond
814a957b12
Begin copying new deck logic
2024-12-30 09:59:38 -05:00
Nathaniel Bond
8a2f636dcf
Attempt initial save guard
2024-12-30 09:48:30 -05:00
Nathaniel Bond
5f19f81936
Enable debugging
2024-12-30 09:48:01 -05:00
Christian McCarty
35a2ef2e9b
Merge pull request #316 from MarcinSc/cost-memory-resolving
...
Cost resolving validation and failure mitigation
2024-12-21 14:08:08 -06:00
MarcinSc
4d12b462a6
Cost check failures can now be ignored, and they are being checked during card definition creation (where validation is added).
2024-12-19 16:29:56 +07:00
MarcinSc
0ef99655cc
Merge remote-tracking branch 'upstream/master' into cost-memory-resolving
2024-12-19 15:04:37 +07:00
MarcinSc
4e3d4a5909
Cost check failures can now be ignored, and they are being checked during card definition creation (where validation is added).
2024-12-19 15:02:53 +07:00
Christian 'ketura' McCarty
172ec04aeb
Fixed the Seeing Stones of Orthanc and Minas Anor always forcing the threats on play and ignoring any Gondor Men with 3 or more vitality.
2024-12-19 00:00:04 -06:00
Christian 'ketura' McCarty
ae6218cb57
Fixed Lorien Swordsman applying the wrong strength debuff (it was making minions strength -2 per wound on the Swordsman himself)
2024-12-18 21:28:48 -06:00
Christian 'ketura' McCarty
4b72cb8d02
Fixed Terribla as the Dawn errata (and any other card that triggers on special abilities) triggering on discard-to-heal.
2024-12-18 17:22:51 -06:00
Christian 'ketura' McCarty
03f8797334
Fixed Rallying Call failing to add threats if the twilight pool was at exactly 0 after playing the southron. (This should also address some other various play-from-hand effects that would encounter the same problem at exactly 0).
...
- Also fixed Dark Shape Sprang unit test and Cirdan-downstream unit test framework change
2024-12-18 12:56:26 -06:00
Christian 'ketura' McCarty
2d65d32e48
Adding tests for Cirdan errata (converted from older tests)
2024-12-18 12:54:32 -06:00
Christian 'ketura' McCarty
f143dc561f
Draft fixes
...
- Fixed draft mode showing random sites instead of clustering by site number
- Changed behavior of the card filter to interpret a provided stat with no comparator as an EQUALS comparator
- Added draft definition reloading to the admin definition refresh
2024-12-18 09:38:12 -06:00
Christian 'ketura' McCarty
3eabebbfb8
Fixed A Dark Shape Sprang not initiating the extra skirmish phase properly.
2024-12-18 00:51:37 -06:00
Christian 'ketura' McCarty
aa20747d3a
Fixed **Gothmog, Lieutenant of Morgul** making Freeps wound X companions instead of wounding companions for each X.
2024-12-18 00:16:44 -06:00
Christian 'ketura' McCarty
467d084d38
Fixed Steps of Edoras defender bonus expiring immediately instead of lasting until the end of the turn.
2024-12-17 23:21:14 -06:00
Christian 'ketura' McCarty
80c12f9960
Fixed a crash when Rush of Steeds is used to cancel Advance Scout.
2024-12-17 23:14:02 -06:00
Christian 'ketura' McCarty
31d462324b
Fixed The World Ahead being unplayable (it was looking for "self" instead of "elf")
2024-12-17 22:19:08 -06:00
Christian 'ketura' McCarty
def5bbc0d3
Fixed Depart Silently only checking for site number and not block. This should now behave properly on non-Fellowship site paths.
2024-12-17 22:11:38 -06:00
Christian 'ketura' McCarty
78ddaa1799
Fixed Besieging Pike pumping itself instead of bearer.
2024-12-17 22:09:11 -06:00
Christian 'ketura' McCarty
1424bb6732
Flood Insurance Test Suite + fixes
...
- Refactored the flood insurance cards. Added extensive unit tests for them so they should stop being so derpy in-game.
- Fixed cards that add a variable number of threats always failing to add any (Threats on All Sides, Plotting)
- Added WasPlayedFromZone requirement that can be used to detect where a card was played from (as used by the flood insurance to disallow one ability if played from deck)
- Fixed a long-standing test bug with the SkipToSite operation. Adjusted tests which used that functionality.
- Altered the default site 3 used for Fellowship Block tests so that it isn't Council Courtyard (screwing with the twilight count).
2024-12-17 22:06:03 -06:00
Christian 'ketura' McCarty
54ecc5c171
Adding new WasPlayedFromZone requirement for tracking where the current card was played from
2024-12-17 18:36:28 -06:00
Christian 'ketura' McCarty
1236c33ac2
Fixed Vengeance not adding strength
2024-12-17 14:52:29 -06:00
Christian 'ketura' McCarty
be9ac40710
Fixed Anguish only working on Moria orcs instead of Sauron orcs.
2024-12-17 12:52:30 -06:00
Christian 'ketura' McCarty
529a2222ac
Fixed Morgul Squealer not discounting draw deck nazgul
2024-12-17 12:51:20 -06:00
Christian 'ketura' McCarty
279a9c92f5
Fixing Mumak Commander, GATS not being able to target a companion with 2 vitality (which should also do the same for any other multi-exert effects)
2024-12-17 12:49:31 -06:00
Christian 'ketura' McCarty
a551c034b0
Fixing malformed Alatar definition
2024-12-17 12:45:06 -06:00
Christian 'ketura' McCarty
509cfcf528
Fixed Alatar Deceived not having damage +1. Fixed Radagast Deceived not having the race of Wizard.
2024-12-17 12:22:34 -06:00
Christian 'ketura' McCarty
16fbb7c3ce
Fixed V2 Dunlending Raider discounting by -1 instead of -2.
2024-12-17 12:20:08 -06:00
Christian 'ketura' McCarty
d3762afe27
Fixed Hobbitses Are Dead not activating from the discard pile.
2024-12-17 12:12:35 -06:00
Christian 'ketura' McCarty
a46c1ae72e
Fixed Sting, Bane of the Eight Legs not triggering during a fierce skirmish.
2024-12-17 11:56:01 -06:00
Christian 'ketura' McCarty
284e44976c
Overhauled assignment definitions
...
- Assignments now require 3 flags: whether an assignment is to ignore existing assignments (false for actions, false for freeps assignments, true for shadow assignments, true for mordor assassin), whether an assignment is to ignore defender bonuses (true for actions, false for freeps assignments, true for shadow assignments, true for mordor assassin), and whether allies are to be considered valid targets (false for everything except for certain abilities)
2024-12-17 09:30:45 -06:00
Christian 'ketura' McCarty
13ff6be1d0
Fixed assignment abilities causing issues with defender +1. Fixed Shadow assignment abilities making the Shadow player re-assign those minions later (which causes an error).
2024-12-17 00:13:56 -06:00
Christian 'ketura' McCarty
f3cf5bf79c
Fixing Protecting the Hall not adding defender bonus to bearer
2024-12-16 23:35:57 -06:00
Christian 'ketura' McCarty
b0e9ce196d
Fixed Alcarin, Warrior of Lamedon assignment ability never being eligible.
2024-12-16 22:45:21 -06:00
Christian 'ketura' McCarty
dbb758d48f
Denethor errata test failure
2024-12-15 20:08:01 -06:00
Christian 'ketura' McCarty
deb8f4dc86
Various fixes
...
- Fixing V2 Uruk Shield Wall blocking skirmish wounds
- Fixing Denethor errata still being strength 5
- Fixing NRE for a certain card lookup
2024-12-15 19:55:47 -06:00
Christian 'ketura' McCarty
7ea62d19b5
Fixed V2 Legion of Isengard affecting all skirmishes and not just its own
2024-12-13 12:48:00 -06:00
Christian 'ketura' McCarty
75ea164ef3
Fixed Safe Passage not being optional.
2024-12-13 12:31:59 -06:00
Christian 'ketura' McCarty
7c02ea8ad9
Adjusted the trigger for Last Days; it should no longer regularly trigger twice.
2024-12-13 12:30:53 -06:00
Christian 'ketura' McCarty
b645cd281e
Fixed a crash caused by some cards that play cards from stacked (such as Flung into the Fray)
2024-12-12 08:11:52 -06:00
Christian 'ketura' McCarty
f8a1b8e177
Fixed packs not having a count on them in the deckbuilder. Hopefully addressed card pack deliveries being out of sync.
2024-12-11 23:32:14 -06:00
Christian 'ketura' McCarty
ec3f01658b
Fixed Anduin River subtracting from minion archery total instead of fellowship
2024-12-11 22:53:41 -06:00
Christian 'ketura' McCarty
1b32ecf7b2
Fixing a number of card abilities that are activatable in 2 phases only being defined in 1
2024-12-11 22:32:10 -06:00
Christian 'ketura' McCarty
627b705b53
Fixed sites with optional triggers being triggerable by the wrong player (Shadows Prancing Pony, Shadows Green Dragon Inn, and others)
2024-12-11 22:23:18 -06:00
Christian 'ketura' McCarty
1c3a07557c
Fixed a rare issue where killing Sam as a response to his response to Frodo dying causing the game to fail to detect the Ring-bearer had died. (If for example the new Terrible as the Dawn errata kills Sam as he responds)
2024-12-11 21:14:18 -06:00
Christian 'ketura' McCarty
7def1402f4
- Fixed Quelled crashing the game
2024-12-11 18:50:28 -06:00
