From a9348b1a372118d074a512fd7a5b7cb809735acd Mon Sep 17 00:00:00 2001
From: Christian 'ketura' McCarty <hyperlink.teltura@gmail.com>
Date: Wed, 2 Nov 2022 17:49:58 -0500
Subject: [PATCH] Fleshing out HTTP logging

---
 .../async/GempukkuHttpRequestHandler.java     | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/gemp-lotr/gemp-lotr-async/src/main/java/com/gempukku/lotro/async/GempukkuHttpRequestHandler.java b/gemp-lotr/gemp-lotr-async/src/main/java/com/gempukku/lotro/async/GempukkuHttpRequestHandler.java
index fec052c67..e8c54d5ab 100644
--- a/gemp-lotr/gemp-lotr-async/src/main/java/com/gempukku/lotro/async/GempukkuHttpRequestHandler.java
+++ b/gemp-lotr/gemp-lotr-async/src/main/java/com/gempukku/lotro/async/GempukkuHttpRequestHandler.java
@@ -95,12 +95,25 @@ public class GempukkuHttpRequestHandler extends SimpleChannelInboundHandler<Full
         ResponseSender responseSender = new ResponseSender(ctx, httpRequest);
 
         try {
-            if (isBanned(requestInformation.remoteIp))
+            if (isBanned(requestInformation.remoteIp)) {
                 responseSender.writeError(401);
-            else
+                _log.trace("Denying entry to user from banned IP " + requestInformation.remoteIp);
+            }
+            else {
                 _uriRequestHandler.handleRequest(uri, httpRequest, _objects, responseSender, requestInformation.remoteIp);
+            }
         } catch (HttpProcessingException exp) {
-            _log.error("Http error while processing request", exp);
+            int code = exp.getStatus();
+            //401, 403, 404, and other 400 errors should just do minimal logging,
+            // but 400 itself should error out
+            if(code % 400 < 100 && code != 400) {
+                _log.trace("HTTP " + code + " response for " + requestInformation.remoteIp + ": " + requestInformation.uri);
+            }
+            // record an HTTP 400
+            else if(code == 400 || code % 500 < 100) {
+                _log.error("HTTP code " + code + " response for " + requestInformation.remoteIp + ": " + requestInformation.uri, exp);
+            }
+
             responseSender.writeError(exp.getStatus());
         } catch (Exception exp) {
             _log.error("Error while processing request", exp);